Port codebase to Genuine MicroPython on ESP32 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
changed the title
|
Thanks a bunch, @poesel. One last nit:
Can you remove this from the PR and add it to [1] https://github.com/DFRobot/DFRobot_MAX17043/blob/master/micropython/DFRobot_MAX17043.py |
I will just merge it right now. Thanks again! |
amotl
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got confused a bit by git. This is why this is not from a branch.
Also the inclusion of the DFRobot lib will also be necessary only when I write the sensor part for the MAX17043. We can find a better place for it later.
Also added some docstrings to get a better grip on how sensors work.